Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch registry argument to register from positional to keyword. #35

Merged
merged 1 commit into from
May 16, 2021

Conversation

GunnarFarneback
Copy link
Owner

This is a breaking change to switch the registry argument to register from a positional argument to a keyword argument. Cf #30.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2021

Codecov Report

Merging #35 (7840f5c) into master (9d3a765) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   98.28%   98.31%   +0.02%     
==========================================
  Files           1        1              
  Lines         175      178       +3     
==========================================
+ Hits          172      175       +3     
  Misses          3        3              
Impacted Files Coverage Δ
src/LocalRegistry.jl 98.31% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3a765...7840f5c. Read the comment docs.

@GunnarFarneback GunnarFarneback merged commit 9f4a4f1 into master May 16, 2021
@GunnarFarneback GunnarFarneback deleted the registry_as_keyword branch May 16, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants