Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around git terminal corruption on Windows. #77

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

GunnarFarneback
Copy link
Owner

Fixes #76.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a97f2e3) 96.83% compared to head (5fb9c5e) 96.93%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   96.83%   96.93%   +0.09%     
==========================================
  Files           1        1              
  Lines         253      261       +8     
==========================================
+ Hits          245      253       +8     
  Misses          8        8              
Files Coverage Δ
src/LocalRegistry.jl 96.93% <88.88%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GunnarFarneback GunnarFarneback merged commit eb8ba40 into master Nov 14, 2023
7 of 11 checks passed
@GunnarFarneback GunnarFarneback deleted the windows_terminal_corruption branch November 14, 2023 07:58
@BambOoxX
Copy link

FYI, something else was broken by this workaround, I got an error regarding the path of the folder containing the git repo, which seems to be cut somewhere leading to and invalid path... v0.5.5 works fine.

@GunnarFarneback
Copy link
Owner Author

If you can reproduce it, it would be good with some details, but I guess it's something to do with a path with spaces and needing to quote it somehow for cmd?

@BambOoxX
Copy link

@GunnarFarneback I tested it again, and it seems it fails on a & in the path, so pretty much what you said.

@KeithWM
Copy link

KeithWM commented Mar 15, 2024

@GunnarFarneback Is this worth fixing, or should there be an effort to implement #38 ? I'd be happy to help any way I can.

@GunnarFarneback
Copy link
Owner Author

If someone can find the right way to quote things it would be useful for documentation but #38 is the way forward, now in the form of a package extension. The best way to help out is to test it and review the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL formatting messed up after LocalRegistry calls
4 participants