-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release async read write for tokio v0.4.0 #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially if the reader is not buffered this will cause a lot of sys read calls. If the IO is buffered your ok. The current reading into a buffer and then attempting to deserialize from it is a bit tideious.
The approach is complicated and usecase minimal. Thus removing
Removing concurrent event handler Renaming mutable event handler to normal event handler
Benchmarks are being removed as they are not possible anymore with the public api. Additionally, they are not as up to date anymore
GunnarMorrigan
changed the title
Release/async io wip
Release async read write for tokio v0.4.0
Nov 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 79.70% 88.07% +8.36%
==========================================
Files 32 51 +19
Lines 5850 5998 +148
==========================================
+ Hits 4663 5283 +620
+ Misses 1187 715 -472 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses async reading and writing more heavily. In the past (and still for smol) data was copied to a buffer.
Parse attempts were made, these could fail and in some cases warrant a retry. For example, when not enough data is present parsing is aborted and should be retried.
This is problematic on slower connections where data comes in chunks, multiple parse attempts could be made for a single message. Due to applying async this is not the case anymore.
Writing should not see much difference
Use a buffered stream! :)
Other changes: