Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for scipy 1.11.x #124

Closed
wants to merge 1 commit into from
Closed

Conversation

torressa
Copy link
Member

@torressa torressa commented Nov 27, 2023

Related to #121 scipy >=1.11 has changed the behavior from the release notes:

A new public base class scipy.sparse.sparray was introduced, allowing further extension of the sparse array API (such as the support for 1-dimensional sparse arrays) without breaking backwards compatibility. isinstance(x, scipy.sparse.sparray) to select the new sparse array classes, while isinstance(x, scipy.sparse.spmatrix) selects only the old sparse matrix classes.

This got missed in the actions for #121 (and every commit since) as the Python version used there was 3.8 for which scipy 1.11.x has no wheel!

@simonbowly This is probably not the correct fix so please take a look.

@torressa torressa changed the title Change spmatrix to sparray, add python versions to actions Changes for scipy 1.11.x Nov 27, 2023
@simonbowly
Copy link
Member

Oversight on my part sorry. I don't think the test really needed to be this strict; a better way to do the return type check is with sp.issparse. This recognises both matrices and arrays and has stayed consistent across scipy versions, so we can leave the requirements as is. I updated that with #126, so I'll close this PR.

@simonbowly simonbowly closed this Dec 1, 2023
@torressa
Copy link
Member Author

torressa commented Dec 1, 2023

Thanks Simon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants