Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy and scipy incompatibilities #149

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Fix numpy and scipy incompatibilities #149

merged 3 commits into from
Jun 27, 2024

Conversation

simonbowly
Copy link
Member

Fixes #148

Adjusts for functions removed in the latest numpy and scipy releases.

@simonbowly
Copy link
Member Author

@torressa does b019e9a look ok to you? It seems to be the recommended fix as getrow was removed in scipy 1.14.

@simonbowly simonbowly requested a review from torressa June 26, 2024 09:58
Copy link
Member

@torressa torressa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon for fixing this! Looks good!

@torressa torressa mentioned this pull request Jun 26, 2024
8 tasks
@simonbowly
Copy link
Member Author

Now I just have the fun of getting those broken doctests working :-(

Don't rely so heavily on the display behaviour of scipy
sparse arrays/matrices
@simonbowly
Copy link
Member Author

Doctests fixed with 784c3bd. It makes the code examples a little wordier but should be more robust.

@simonbowly simonbowly merged commit 9d86d8f into main Jun 27, 2024
9 checks passed
@simonbowly simonbowly deleted the fix-deprecations branch July 1, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix numpy 2.0 and scipy 1.14 incompatibilities
2 participants