Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing skip stage #25

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixing skip stage #25

wants to merge 4 commits into from

Conversation

whizzzkid
Copy link
Contributor

In this PR:

  • Adding boolean parsing
  • fixed readme.

@whizzzkid whizzzkid requested a review from ethankhall July 7, 2022 23:53
ethankhall
ethankhall approved these changes Jul 8, 2022
View reviewed changes
core/task.go Outdated
// Explicitly fail the pre-commit hook so the files can be staged manually
success = false
} else {
// Stage files by default automatically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This comment reads weird with the "default" being the else block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethankhall ethankhall ethankhall approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whizzzkid @ethankhall