Added additional flags (cookies from browser, max downloads) #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the following option flags during build :
--cookies-from-browser BROWSER[+KEYRING][:PROFILE][::CONTAINER]
--max-downloads NUMBER
These are just convenience methods for providing better type checking for parameters and help formatting values correctly.
The
--cookies-from-browser
introduces a new way of interacting with the lib with optional parameters that are not present in otherYoutubeDl
methods, and will require users to explicitly passNone
to parameters not needed and wrap needed values inSome()
, could add more complete documentation for the function to explicit this point if needed.To clarify the goal of this implementation, requiring the user to pass an already formatted
String
respecting the formatBROWSER[+KEYRING][:PROFILE][::CONTAINER]
required byyt-dlp
would be needless as it would only be a wrapper aroundextra_arg
that would stay just as prone to error, and other implementations using structs and traits would have added too much to the global architecture of the lib and potential future overhead, so thanks to optional parameters, the logic has been kept straightforward and contained inside the function.