Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare earth oriented pols. #206

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

aewallwi
Copy link
Collaborator

Closes #205

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #206 (328a365) into main (15e35fe) will decrease coverage by 0.13%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   96.48%   96.35%   -0.14%     
==========================================
  Files          24       24              
  Lines        2792     2800       +8     
==========================================
+ Hits         2694     2698       +4     
- Misses         98      102       +4     
Impacted Files Coverage Δ
hera_sim/visibilities/vis_cpu.py 90.97% <50.00%> (-2.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebed9d...328a365. Read the comment docs.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aewallwi. I do believe this is correct (though it always hurts my brain to think about the polarizations/feeds between uvbeam and uvdata).

Before approving, I'd like to see a short update to the changelog, and if possible, a test that would have failed previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible for beam x/y pols to incorrectly be compared to uvdata directional pols.
2 participants