Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: exploration of better matmul algorithms #69

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Sep 29, 2023

This adds a notebook that explores different ways to do the V = Z.dot(Z.T.conj()) calculation.

Ideas that I haven't yet explored:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d45e9bc) 100.00% compared to head (af6f273) 65.07%.
Report is 28 commits behind head on main.

❗ Current head af6f273 differs from pull request most recent head 48d83f7. Consider uploading reports for the commit 48d83f7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #69       +/-   ##
============================================
- Coverage   100.00%   65.07%   -34.93%     
============================================
  Files            8        8               
  Lines          567      567               
  Branches        88       88               
============================================
- Hits           567      369      -198     
- Misses           0      193      +193     
- Partials         0        5        +5     
Flag Coverage Δ
unittests 64.72% <ø> (-34.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkolopanis
Copy link
Member

If you're going through all the efforts of writing a cublas implementation, might investigated compiled extensions like cython or a rust extension. Both have interop with numpy which is pretty straightforward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants