Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove un-needed initial state? #2843

Merged
merged 6 commits into from
Sep 27, 2024
Merged

chore: remove un-needed initial state? #2843

merged 6 commits into from
Sep 27, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Sep 23, 2024 •
edited
Loading

What changed

In our ENG Collab meeting from 9/23/24, we discussed removing this un-needed initial-state.json from our Cypress End to End tests.

Issue

#346

How to test

  1. E2E tests pass

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr self-assigned this Sep 23, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review September 23, 2024 16:09
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Sep 23, 2024
@fpigeonjr fpigeonjr mentioned this pull request Sep 23, 2024
Merged
9 tasks
@fpigeonjr fpigeonjr merged commit 37add4b into main Sep 27, 2024
40 checks passed
@fpigeonjr fpigeonjr deleted the OPS/e2e-experiment branch September 27, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiyerlee maiyerlee maiyerlee approved these changes

@johndeange johndeange johndeange approved these changes

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@devops-chris devops-chris Awaiting requested review from devops-chris

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@fpigeonjr fpigeonjr

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpigeonjr @johndeange @maiyerlee