[Issue: 1291] Update cd-* scripts to deploy staging #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplybeah
requested review from
acouch,
chouinar and
SammySteiner
as code owners
chouinar
previously approved these changes
Apr 24, 2024
coilysiren
requested changes
Apr 24, 2024
| @@ -20,6 +20,7 @@ on: | |||
| type: choice | |||
| options: | |||
| - dev | |||
| - staging | |||
There was a problem hiding this comment.
Unfortunately adding staging here won't change much. It just makes staging available as an option, but doesn't actually start deploying staging. The line you want to change is down below...
| @@ -20,6 +20,7 @@ on: | |||
| type: choice | |||
| options: | |||
| - dev | |||
| - staging | |||
| - prod | |||
|
|
|||
There was a problem hiding this comment.
...the line you want to change is this one down below
environment: ${{ inputs.environment || (github.event_name == 'release' && 'prod') || 'dev' }}
change it to (psuedo-code)
environment: ${{ inputs.environment || (github.event_name == 'release' && 'prod') || ['dev', 'staging'] }}
There was a problem hiding this comment.
You'll need to do this for the analytics package as well, of course.
coilysiren
reviewed
Apr 24, 2024
| @@ -20,6 +20,7 @@ on: | |||
| type: choice | |||
There was a problem hiding this comment.
You'll need to change run-name: above as well
coilysiren
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1291
Fixes #1549
Time to review: 1 min
Changes proposed
staginginput tocd-apiandcd-frontendfilesContext for reviewers
Additional information
N/A