Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1853] Move where we define the lookup mapping to avoid constant import issues #1854

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

chouinar
Copy link
Collaborator

Summary

Fixes #1853

Time to review: 1 mins

Changes proposed

Move where we define the LookupConfig definitions to reduce circular dependencies

Context for reviewers

This doesn't change the configs, just where they're defined. We frequently want to import the enums defined in lookup_constants, but because that file in turn depends on the DB lookup files, we run into some odd circular dependencies that require manually sorting imports to resolve. Instead, we'll just define those LookupConfig classes in the only place they're ever used to avoid the headache.

@chouinar chouinar merged commit 365918c into main Apr 26, 2024
8 checks passed
@chouinar chouinar deleted the chouinar/fix-import-problems branch April 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Move where we define the lookup mappings to avoid circular dependency issues
2 participants