[Issue #1853] Move where we define the lookup mapping to avoid constant import issues #1854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1853
Time to review: 1 mins
Changes proposed
Move where we define the LookupConfig definitions to reduce circular dependencies
Context for reviewers
This doesn't change the configs, just where they're defined. We frequently want to import the enums defined in lookup_constants, but because that file in turn depends on the DB lookup files, we run into some odd circular dependencies that require manually sorting imports to resolve. Instead, we'll just define those LookupConfig classes in the only place they're ever used to avoid the headache.