Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods in base.py to pull to and from SQL tables, unit tests in test_base.py and successful code formatting and quality checks #1938

Closed
wants to merge 2 commits into from

Conversation

ebuwa-evbuoma-fike
Copy link
Collaborator

@ebuwa-evbuoma-fike ebuwa-evbuoma-fike commented May 7, 2024

Summary

Important Note: Work-in-progress #{1599}

Time to review: 10 mins

Changes proposed

  • Create db.py, to establish a connection to the database using a SQLAlchemy engine object.
  • Create the to_sql and from_sql methods in base.py.
  • Set up database configurations.
  • Create and validate unit tests in test_base.py.

Context for reviewers

For @widal001 and @AlexanderStephensonUSDS working async.

Additional information

Code formatting and quality checks passed:

Screenshot 2024-05-10 at 3 13 32 PM Screenshot 2024-05-10 at 2 43 31 PM

@coilysiren
Copy link
Collaborator

You can convert this to a draft PR if it is still "work in progress" as the description says

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

@ebuwa-evbuoma-fike
Copy link
Collaborator Author

You can convert this to a draft PR if it is still "work in progress" as the description says

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

@coilysiren can draft PRs be viewed? My goal was to make sure Alex could access this

@coilysiren
Copy link
Collaborator

@ebuwa-evbuoma-fike

can draft PRs be viewed? My goal was to make sure Alex could access this

Yes draft PRs have the same visibility rules as normal PRs

@ebuwa-evbuoma-fike ebuwa-evbuoma-fike marked this pull request as draft May 7, 2024 18:54
…n test_base.py, and successful code quality and formatting checks
@ebuwa-evbuoma-fike ebuwa-evbuoma-fike changed the title Created db.py, updated to_sql method in base.py Methods in base.py to pull to and from SQL tables, unit tests in test_base.py and successful code formatting and quality checks May 10, 2024
@acouch
Copy link
Collaborator

acouch commented Oct 16, 2024

The code from this PR was adopted during the break with this PR navapbc#72

@acouch acouch closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants