Update Next.js #2014
Merged
Update Next.js #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
requested review from
andycochran,
acouch and
SammySteiner
as code owners
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 90.6% | 790/872 |
| 🟡 | Branches | 71.79% | 224/312 |
| 🟢 | Functions | 87.89% | 167/190 |
| 🟢 | Lines | 91.27% | 742/813 |
Test suite run success
178 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from a4fa641
renovate
bot
force-pushed
the
renovate/next.js
branch
2 times, most recently
from
a2b6f43
to
0aaff85
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
2 times, most recently
from
0fdb6c8
to
6abf8fd
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
from
6abf8fd
to
df60fe7
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
6 times, most recently
from
fa2fd59
to
bfd1c26
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
from
bfd1c26
to
32433ff
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
from
32433ff
to
4031d2e
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
2 times, most recently
from
af7e537
to
29c0b99
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
5 times, most recently
from
bcb073a
to
7f8b24f
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
from
7f8b24f
to
d584461
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
3 times, most recently
from
9a9380b
to
0bd892c
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
3 times, most recently
from
0d68581
to
d30933c
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
7 times, most recently
from
e21c375
to
dc58d4f
Compare
doug-s-nava
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Notes from my review:
- Started up locally on this branch and the app seems to be functioning as expected as far as loading and navigation between static pages
- Ran linter locally and it ran with no errors (beyond a note that the Typescript version on the project is too new to be fully supported by
typescript-eslint) - The search page seems broken on this branch the same way it is on main, so no red flags there
- Since it looks like I need to get the API running to test the
opportunitiespage, I have not been able to do that yet, but working on it and will report back on results when I have them - When running an
npm installon this branch using node 20.17 I got a lot of changes to the package lock related to using a newer version on npm. Since theenginesin the package.json specify >20 I'm not sure what to make of this. Tried to do an install with node 10 to test behavior there but it errored out on an optional chain. - During the install I also get errors related to three packages, though these errors also appear when running the install on main:
string-width-cjs: No matching version found for [email protected]strip-ansi-cjs: No matching version found for [email protected].wrap-ansi-cjs: No matching version found for [email protected].
So that's what I'm seeing. Nothing seems like a blocker other than maybe the question of the lockfile version / npm version, but not sure what exactly is expected here so I'll hold off on approving
|
After spinning up the API server, can confirm that the search and opportunity pages function as expected. |
renovate
bot
force-pushed
the
renovate/next.js
branch
4 times, most recently
from
1f523e1
to
27a9521
Compare
acouch
approved these changes
Sep 20, 2024
renovate
bot
force-pushed
the
renovate/next.js
branch
2 times, most recently
from
cc90f69
to
cb93b3a
Compare
renovate
bot
force-pushed
the
renovate/next.js
branch
from
cb93b3a
to
a4fa641
Compare
|
@doug-s-nava Thanks for the review. Please merge!
Can you create an issue? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
13.5.6->13.5.714.2.8->14.2.133.19.1->3.19.4Release Notes
vercel/next.js (eslint-config-next)
v13.5.7Compare Source
vercel/next.js (next)
v14.2.13Compare Source
v14.2.12Compare Source
v14.2.11Compare Source
v14.2.10Compare Source
v14.2.9Compare Source
amannn/next-intl (next-intl)
v3.19.4Compare Source
Bug Fixes
v3.19.3Compare Source
Bug Fixes
v3.19.2Compare Source
Bug Fixes
Configuration
📅 Schedule: Branch creation - "on the 2nd and 4th day instance on sunday after 9pm" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.