[Issue #2177] Fix facet count name issue #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdragon
approved these changes
Sep 19, 2024
Yes - mostly it is there to make sure everything you expect is configured. Likely will add more in-depth tests once the feature gets used (verifying the exact counts returned). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2177
Time to review: 3 mins
Changes proposed
Fixed issue with facet count names which was causing the opportunity status to be populated incorrectly
Added a test to prevent issue in the future
Context for reviewers
These fields aren't used yet - just a minor bug I noticed when setting up the demo the other day