Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1868] Enforce absolute imports outside of the same directory #2192

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

acouch
Copy link
Collaborator

@acouch acouch commented Sep 23, 2024

Summary

Fixes #1868

Time to review: 5 mins

Changes proposed

Enforces absolute imports outside of the same directory.

andycochran
andycochran previously approved these changes Sep 23, 2024
Copy link
Collaborator

@andycochran andycochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much more legible 👏

Copy link

Coverage report for ./frontend

St.
Category Percentage Covered / Total
🟢 Statements 90.6% 790/872
🟡 Branches 71.79% 224/312
🟢 Functions 87.89% 167/190
🟢 Lines 91.27% 742/813

Test suite run success

178 tests passing in 54 suites.

Report generated by 🧪jest coverage report action from bb2c161

Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@acouch acouch merged commit c3590d8 into main Sep 23, 2024
12 checks passed
@acouch acouch deleted the issue-1868-enforce-abs-imports branch September 23, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Enforce absolute imports for frontend
3 participants