[Issue #680] Add basic CDN configuration #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
reviewed
Dec 3, 2024
infra/modules/service/cdn.tf
Outdated
| # Default to caching for 1 hour, with a minimum of 1 minute. | ||
| # The default TTL can be overriden by the `Cache-Control max-age` or `Expires` headers | ||
| # There's also a `max_ttl` option, which can be used to override the above headers. | ||
| min_ttl = 60 |
There was a problem hiding this comment.
Think we might want this as 0 is we set those in the app with the s-maxage= https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html#ExpirationDownloadDist
There was a problem hiding this comment.
I had this as 0 at first! I'll put it back
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #680
Time to review: 20 mins
Changes proposed
Testing
https://d3oegia17k54zs.cloudfront.net/
You can have the load balancer available at the same time as the CDN: http://frontend-staging-1506108424.us-east-1.elb.amazonaws.com/. That said, after we roll this to production and test it, we should block public access to the load balancer, and swap the simpler.grants.gov CNAME over to the CDN.