[Issue #3293] Create POST /users/:userId/saved-opportunities API schema and stub endpoint #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…https://github.com/HHS/simpler-grants-gov into mikehgrantsgov/3291-create-saved-opportunities-model
…nto mikehgrantsgov/3293-create-save-opp-api
mikehgrantsgov
changed the base branch from
main
to
mikehgrantsgov/3291-create-saved-opportunities-model
Co-authored-by: Michael Chouinard <[email protected]>
…nto mikehgrantsgov/3293-create-save-opp-api
chouinar
reviewed
Dec 20, 2024
Comment on lines
10
to
12
| user = UserFactory.create() | ||
| token, _ = create_jwt_for_user(user, db_session) | ||
| db_session.commit() |
There was a problem hiding this comment.
We could use a test utility that is like "get_test_user" that we'll eventually be able to pass things like roles into for a given unit test. Might be worth looking into setting that up.
There was a problem hiding this comment.
I did abstract this slightly to remove duplication. I suppose the fixture I added could be added to conftest?
Co-authored-by: Michael Chouinard <[email protected]>
…nto mikehgrantsgov/3293-create-save-opp-api
Base automatically changed from
mikehgrantsgov/3291-create-saved-opportunities-model
to
main
December 20, 2024 19:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3293
Time to review: 20 mins
Changes proposed
Create an API for users to save opportunities.
Make sure this API is scoped to the currently logged in user
Response body a basic success message
Additional information
See attached unit tests