-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 3266] mod factories opp attach staging #3370
Open
babebe
wants to merge
15
commits into
main
Choose a base branch
from
3266/mod_factories_opp_attach_staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
babebe
changed the title
3266/mod factories opp attach staging
[Issue 3266] mod factories opp attach staging
Jan 2, 2025
chouinar
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was some confusion on this ticket - you are making new factories - do not modify the existing TopportunityFactory in any way.
api/tests/src/data_migration/transformation/subtask/test_transform_opportunity_attachment.py
Outdated
Show resolved
Hide resolved
github-actions
bot
requested review from
acouch,
andycochran,
btabaska,
coilysiren,
doug-s-nava and
widal001
as code owners
January 3, 2025 20:57
…b.com/HHS/simpler-grants-gov into 3266/mod_factories_opp_attach_staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #{3266}
Time to review: 10 mins
Changes proposed