cleanup

HJLebbink · Jun 4, 2018 · 999dfb3 · 999dfb3
1 parent 64676e2
commit 999dfb3
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 18 deletions.
diff --git a/VS/CSHARP/asm-dude-vsix/CodeFolding/CodeFoldingTagger.cs b/VS/CSHARP/asm-dude-vsix/CodeFolding/CodeFoldingTagger.cs
@@ -119,7 +119,6 @@ public IEnumerable<ITagSpan<IOutliningRegionTag>> GetTags(NormalizedSnapshotSpan
                     int startLineNumber = entire.Start.GetContainingLine().LineNumber;
                     int endLineNumber = entire.End.GetContainingLine().LineNumber;
 
-                    //foreach (Region region in this._regions.ToArray()) //TODO expensive and ugly ToArray here to prevent a modification exception
                     foreach (Region region in this._regions)
                     {
                         if ((region.StartLine <= endLineNumber) && (region.EndLine >= startLineNumber))

diff --git a/VS/CSHARP/asm-dude-vsix/HighlightWord/HighlightWordTagger.cs b/VS/CSHARP/asm-dude-vsix/HighlightWord/HighlightWordTagger.cs
@@ -213,7 +213,7 @@ private void Update_Word_Adornments()
                         {
                             //AsmDudeToolsStatic.Output_INFO(string.Format("{0}:Update_Word_Adornments. Keyword={1}", this.ToString(), this.NewWord));
                             //We have to replace all occurrences of special characters with escaped versions of that char since we cannot use verbatim strings.
-                            string t = this.NewWord.Replace(".", "\\.").Replace("$", "\\$").Replace("?", "\\?").Replace("/", "\\/"); //TODO escape backslashes
+                            string t = this.NewWord.Replace(".", "\\.").Replace("$", "\\$").Replace("?", "\\?").Replace("/", "\\/");
                             findData = new FindData(t, s)
                             {
                                 FindOptions = FindOptions.WholeWord | FindOptions.SingleLine | FindOptions.UseRegularExpressions

diff --git a/VS/CSHARP/asm-dude-vsix/OptionsPage/AsmDudeOptionsPage.cs b/VS/CSHARP/asm-dude-vsix/OptionsPage/AsmDudeOptionsPage.cs
@@ -1291,7 +1291,7 @@ private void Save()
                 if (Settings.Default.SyntaxHighlighting_Opcode_Italic != this._asmDudeOptionsPageUI.ColorMnemonic_Italic)
                 {
                     Settings.Default.SyntaxHighlighting_Opcode_Italic = this._asmDudeOptionsPageUI.ColorMnemonic_Italic;
-                    //TODO
+                    //TODO fix that toggling italic is displayed immediately
                     //UpdateItalic(AsmClassificationDefinition.ClassificationTypeNames.Mnemonic, this._asmDudeOptionsPageUI.ColorMnemonic_Italic);
                     changed = true;
                     restartNeeded = true;

diff --git a/VS/CSHARP/asm-dude-vsix/Tools/AsmDudeToolsStatic.cs b/VS/CSHARP/asm-dude-vsix/Tools/AsmDudeToolsStatic.cs
@@ -157,21 +157,6 @@ public static string GetFileName(ITextBuffer buffer)
             return null;
         }
 
-        public static bool Proper_File(ITextBuffer buffer)
-        {
-            string filename = GetFileName(buffer);
-            if ((filename == null) ||
-                (filename.Length == 0) ||
-                (filename.EndsWith(".asm", StringComparison.OrdinalIgnoreCase)) ||
-                (filename.EndsWith(".cod", StringComparison.OrdinalIgnoreCase)) ||
-                (filename.EndsWith(".inc", StringComparison.OrdinalIgnoreCase)) ||
-                (filename.EndsWith(".s", StringComparison.OrdinalIgnoreCase)))
-            {
-                return true;
-            }
-            return false;
-        }
-
         public static void Open_Disassembler()
         {
             try