Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased bottom margin for the footer #1480

Closed
wants to merge 1 commit into from

Conversation

gunjjoshi
Copy link

@gunjjoshi gunjjoshi commented Jan 3, 2024

Added a new class named "user-footer" in the footer inside default.html.
Set a bottom margin for the same class in hsf.css

Before:
Screenshot 2024-01-03 at 11 22 47

After:
Screenshot 2024-01-03 at 11 23 21

Now, it looks better.

Closes #1472

@klieret
Copy link
Member

klieret commented Jan 5, 2024

Hi @gunjjoshi . Thank you for your PR. But wasn't this addressed in #1476 ?

Also I see a lot of unrelated formatting (?) changes.

@klieret
Copy link
Member

klieret commented Jan 5, 2024

I'm going to close this, because I believe it's a duplicate of the earlier #1476 , but let me know if this is incorrect.

@klieret klieret closed this Jan 5, 2024
@gunjjoshi
Copy link
Author

Hi @gunjjoshi . Thank you for your PR. But wasn't this addressed in #1476 ?

Also I see a lot of unrelated formatting (?) changes.

There is an issue over there, as mentioned by you:
image

So, for this reason, I made another PR, fixing the same thing, now the margin is only from the bottom, unlike the one in #1476 , which is coming both upwards and downwards.

@klieret
Copy link
Member

klieret commented Jan 5, 2024

#1476 was updated in the meantime to only affect the bottom though (and this is the version which I just merged and that is now live at https://hepsoftwarefoundation.org/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient bottom margin
2 participants