docs: add new code comments and fix wrong ones

HSLdevcom · Jan 28, 2022 · 3bfc4d9 · 3bfc4d9
1 parent 1c057bc
commit 3bfc4d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/controller/predicates/is_plain_multiword_name.js b/controller/predicates/is_plain_multiword_name.js
@@ -2,11 +2,13 @@ const _ = require('lodash');
 
 module.exports = (req, res) => {
   if (req.clean.hasOwnProperty('parsed_text')) {
+    // do not match name with admins if name is a street addr or explict admin value was parsed from text
     if(req.clean.parsed_text.hasOwnProperty('number') && req.clean.parsed_text.hasOwnProperty('street') ||
        req.clean.parsed_text.regions
     ) {
       return false;
     }
+    // no street, no admins - maybe the name itself includes an admin: 'Vilppulan asema'
     return req.clean.parsed_text.name && req.clean.parsed_text.name.includes(' ');
   }
   return false;

diff --git a/routes/v1.js b/routes/v1.js
@@ -245,15 +245,15 @@ function addRoutes(app, peliasConfig) {
     isAddressItParse
   );
 
-  // call very old prod query if addressit was the parser
+  // try genitive matching if search seems to need it
   const genitiveQueryShouldExecute = all(
     not(hasRequestErrors),
     not(hasGoodMatch),
     isPlainMultiWordName,
     isAddressItParse
   );
 
-  // call very old prod query if addressit was the parser
+  // try fuzzy matching if perfect match was not found
   const fuzzyQueryShouldExecute = all(
     not(hasRequestErrors),
     isAddressItParse,