Added data attributes for buttons

HTMLGuyLLC · Sep 10, 2019 · 20b9e11 · 20b9e11
1 parent 03479ad
commit 20b9e11
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -216,19 +216,27 @@ $('.social-share').jConfirm({
         {
             text:'Facebook',
             event:'facebook-share',
+            data: {
+                some_data_attr: 1
+            },
             class:'facebook-btn jc-button-highlight'
         },
         {
             text:'Twitter',
             event:'twitter-share',
+            data: {
+                some_data_attr: 2
+            },
             class:'twitter-btn jc-button-highlight'
         }
     ]
-}).on('facebook-share', function(e){
+}).on('facebook-share', function(e, data){
     var btn = $(this);
+    var data_attr = btn.data('some_data_attr'); //1
     console.log('Sharing to facebook: '+btn.data('url-to-share'));
-}).on('twitter-share', function(e){
+}).on('twitter-share', function(e, data){
     var btn = $(this);
+    var data_attr = btn.data('some_data_attr'); //2
     console.log('Sharing to twitter: '+btn.data('url-to-share'));
 });
 ```
diff --git a/index.html b/index.html
@@ -335,23 +335,31 @@ <h4>Social Media Sharing:</h4>
             {
                 text:'&lt;i class="fa fa-facebook">&lt;/i> Facebook',
                 event:'facebook-share',
+                data: {
+                    some_data_attr: 1
+                },
                 class:'facebook-btn'
             },
             {
                 text:'&lt;i class="fa fa-twitter">&lt;/i> Twitter',
                 event:'twitter-share',
+                data: {
+                    some_data_attr: 2
+                },
                 class:'twitter-btn'
             }
         ]
     }).on('facebook-share', function(e){
         var btn = $(this);
+        var data_attr = btn.data('some_data_attr'); //1
         var url = 'http://www.facebook.com/sharer.php?u='+btn.data('url-to-share');
         window.open(
           url,
           '_blank'
         );
     }).on('twitter-share', function(e){
         var btn = $(this);
+        var data_attr = btn.data('some_data_attr'); //2
         var url = 'http://twitter.com/share?text=This%20is%20the%20best!&url='+btn.data('url-to-share');
         window.open(
           url,

diff --git a/jConfirm.js b/jConfirm.js
@@ -85,7 +85,16 @@
                 //loop through buttons and add to html
                 $.each(helper.btns, function(key,btn){
                     html += `<div class='jc-button-wrap'>
-                                <a href='#' data-event='${btn.event}' class='jc-button ${btn.class}'>${btn.text}</a>
+                                <a href='#' data-event='${btn.event}' class='jc-button ${btn.class}'`;
+                    if( typeof btn.data === 'object' ){
+                        const data_attrs = btn.data;
+                        for ( let prop in data_attrs ) {
+                            if (Object.prototype.hasOwnProperty.call(data_attrs, prop)) {
+                                html += ` data-${prop}="${data_attrs[prop]}"`;
+                            }
+                        }
+                    }
+                    html += `>${btn.text}</a>
                             </div>`;
                 });
 

diff --git a/jConfirm.min.js b/jConfirm.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jconfirm",
-  "version": "4.4.5",
+  "version": "4.5.0",
   "description": "jQuery confirmation tooltip plugin",
   "author": { 
     "name" : "HTMLGuy, LLC",