Diffuser change upgraded to 0.26.3 along with MLPERF SD XL support #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astachowiczhabana please also take a look |
kumarans-ai
reviewed
Jun 28, 2024
| @@ -257,7 +277,10 @@ def step( | |||
| # 2. Convert to an ODE derivative | |||
| derivative = (sample - pred_original_sample) / sigma_hat | |||
|
|
|||
| dt = sigma_next - sigma_hat | |||
| if self.is_inference: | |||
There was a problem hiding this comment.
can we try to remove this flag , keep it as default implementation/optimal implementation, unless it affects any model
ANSHUMAN87
force-pushed
the
jh-mlpef-diffuser-upstream-fork
branch
from
17da689
to
bfcf437
Compare
kumarans-ai
approved these changes
Jul 3, 2024
kalyanjk
pushed a commit
to kalyanjk/optimum-habana-fork
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JH...!