Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Footer #156

Merged
merged 15 commits into from
Oct 5, 2024
Merged

Updated Footer #156

merged 15 commits into from
Oct 5, 2024

Conversation

ofjuneskies
Copy link
Contributor

Updated Footer. Need to update links and also idk how to change the font.

Changed format and icon images and added buttons that weren't there last year (Apply, Hack icon, etc)

Copy link

github-actions bot commented Oct 1, 2024

Deploy preview for zothacks-site-2023-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 14555d5

Copy link

github-actions bot commented Oct 1, 2024

Deploy preview for zothacks-site-2023 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit 14555d5

@IanWearsHat
Copy link
Member

For some devices like the iPhone XR, the footer floats up from the bottom of the page.

image

--
I tried adding lines 3-5 to the footer class in Footer.module.scss:
image

I also added line 6 to the background class in globals.scss:
image

Once I did this, the footer stuck to the bottom of the page, but I don't know if this is the preferred way of making the footer stick 🤷

@IanWearsHat
Copy link
Member

I also presume we're waiting for Graphics to confirm that we're not going to get sued for the icons, right?

@ofjuneskies
Copy link
Contributor Author

I think its because of the login button which I didn't see before. Do we prefer having that button floating above or underneath all of them?

And yeah I have the official icons ready to switch if needed, just waiting to see what the trademark rules are from graphics. I heard from someone that we might be allowed to use monotone versions of the icon but it's not confirmed.

@waalbert
Copy link
Contributor

waalbert commented Oct 2, 2024

@IanWearsHat I think this happened because there isn't a lot of content on the page yet which is causing the footer to be floating above, so I don't think the fix is necessary because if I remember correctly from last year, the footer was floating before the home page content was added

@waalbert
Copy link
Contributor

waalbert commented Oct 2, 2024

@ofjuneskies The login button is from Vercel and doesn't intrude on anything so no need to worry about it if that's what you're referring to.

apps/site/src/assets/icons/HACK LOGO.svg Outdated Show resolved Hide resolved
apps/site/src/app/(home)/page.tsx Outdated Show resolved Hide resolved
apps/site/src/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
apps/site/src/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
apps/site/src/assets/icons/HACK LOGO.svg Outdated Show resolved Hide resolved
apps/site/src/assets/icons/tiktok.svg Outdated Show resolved Hide resolved
apps/site/src/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
apps/site/src/assets/icons/facebook.svg Outdated Show resolved Hide resolved
@waalbert waalbert merged commit b0b9c0e into main Oct 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants