-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Sticker Positioning #76
Conversation
a25560b
to
53569de
Compare
Deploy preview for zothacks-site-2023 ready!
|
Deploy preview for zothacks-site-2023-sanity ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the sticker position "jumps" as soon as you adjust the window. Sticker positioning changing while resizing has been an issue, so this could be resolved in another PR. Let me know what you think.
Screen.Recording.2023-10-22.at.3.09.59.AM.mov
apps/site/src/components/Sticker/Stickers/HeartSticker/HeartSticker.tsx
Outdated
Show resolved
Hide resolved
bf3e887
to
099765b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the Hack Sticker "jumps" when the window is resized, as shown in the previous video. I'm a bit hesitant to merge into Prod with this behavior.
apps/site/src/views/Home/components/ApplyButton/ApplyButton.tsx
Outdated
Show resolved
Hide resolved
Could you provide a title and include a description of changes in the PR? |
I agree with @taesungh. At least for me, I get the big picture of creating a general use sticker wrapper component around some "anchor", but I am a bit lost on the details of this Sticker API. |
I've added some details documenting the API of the component. The wrapper component uses a flexbox to position the stickers. |
Removes the sticker layer component, and adds a new component to position stickers relative to an element.
The component takes in any element as a child. It also takes in stickers in a prop like so:
The stickers are then positioned relative to one of the corners of the child element.