Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge upstream branch, fix linting of md files and disable prettier to prevent clash with ESLint rules #16

Merged
merged 8 commits into from
Mar 10, 2024
Merged

Merge upstream branch, fix linting of md files and disable prettier to prevent clash with ESLint rules #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
410d8cb
Merge pull request #4 from HackYourFutureBelgium/main
colevandersWands Nov 26, 2023
5197131
just-enough-dom refactor, moving away from dom-io library. and more …
colevandersWands Nov 28, 2023
70086c5
pull & fix conflicts
colevandersWands Nov 28, 2023
d2d270a
update study configs for multiple interactions
colevandersWands Nov 28, 2023
c80ed76
more READMEs, some more DOM IO, a formatting run (sorry!)
colevandersWands Nov 30, 2023
256a113
switch shift/unshift
colevandersWands Dec 6, 2023
22aac09
merge upstream to fork
danielhalasz Mar 6, 2024
02040cd
linting fixed and prettier disabled to prevent eslint rule clash
danielhalasz Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
22 changes: 11 additions & 11 deletions .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"language": "en",
"words": [
"asdf",
"hackyourfuture",
"monospace",
"Precourse",
"distractor",
"distractors",
"typeof"
],
"ignorePaths": ["node_modules/**", "**/*.json", "**/*.mp4", "**/*.svg"]
"language": "en",
"words": [
"asdf",
"hackyourfuture",
"monospace",
"Precourse",
"distractor",
"distractors",
"typeof"
],
"ignorePaths": ["node_modules/**", "**/*.json", "**/*.mp4", "**/*.svg"]
}
212 changes: 106 additions & 106 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,111 +1,111 @@
{
"plugins": ["prettier", "jsdoc", "prefer-arrow", "sonarjs", "jest"],
"env": {
"browser": false
},
"parserOptions": {
"ecmaVersion": 2021,
"sourceType": "script"
},
"globals": {
"prompt": false,
"alert": false,
"confirm": false,
"console": false
},
"extends": [
"eslint:recommended",
"prettier",
"airbnb-base",
"plugin:sonarjs/recommended"
],
"overrides": [
{
"files": ["**.test.js", "**.spec.js"],
"rules": {
"no-magic-numbers": 0
},
"env": {
"jest": true
}
}
],
"rules": {
"no-var": 1,
"prefer-const": 0,
"no-extra-parens": 1,
"no-unreachable-loop": 1,
"eqeqeq": 1,
"no-implicit-coercion": 1,
"no-implicit-globals": 1,
"no-lone-blocks": 1,
"no-return-assign": 1,
"no-unused-expressions": 1,
"no-useless-computed-key": 1,
"no-useless-rename": 1,
"no-label-var": 1,
"no-shadow": 1,
"no-undefined": 1,
"arrow-parens": 1,
"arrow-body-style": 0,
"no-confusing-arrow": 1,
"vars-on-top": 0,
"no-plusplus": 0,
"guard-for-in": 0,
"no-unmodified-loop-condition": 0,
"no-warning-comments": 1,
"prefer-destructuring": 1,
"no-nested-ternary": 0,
"no-empty": 0,
"no-constant-condition": 0,
"no-alert": 0,
"no-console": 0,
"no-continue": 0,
"no-underscore-dangle": 0,
"strict": [2, "global"],
"no-multiple-empty-lines": 0,
"no-restricted-syntax": [
0,
{
"selector": "ForInStatement"
},
{
"selector": "ForOfStatement"
}
],
"camelcase": [2, { "properties": "never" }],
"plugins": ["prettier", "jsdoc", "prefer-arrow", "sonarjs", "jest"],
"env": {
"browser": false
},
"parserOptions": {
"ecmaVersion": 2021,
"sourceType": "script"
},
"globals": {
"prompt": false,
"alert": false,
"confirm": false,
"console": false
},
"extends": [
"eslint:recommended",
"prettier",
"airbnb-base",
"plugin:sonarjs/recommended"
],
"overrides": [
{
"files": ["**.test.js", "**.spec.js"],
"rules": {
"no-magic-numbers": 0
},
"env": {
"jest": true
}
}
],
"rules": {
"no-var": 1,
"prefer-const": 0,
"no-extra-parens": 1,
"no-unreachable-loop": 1,
"eqeqeq": 1,
"no-implicit-coercion": 1,
"no-implicit-globals": 1,
"no-lone-blocks": 1,
"no-return-assign": 1,
"no-unused-expressions": 1,
"no-useless-computed-key": 1,
"no-useless-rename": 1,
"no-label-var": 1,
"no-shadow": 1,
"no-undefined": 1,
"arrow-parens": 1,
"arrow-body-style": 0,
"no-confusing-arrow": 1,
"vars-on-top": 0,
"no-plusplus": 0,
"guard-for-in": 0,
"no-unmodified-loop-condition": 0,
"no-warning-comments": 1,
"prefer-destructuring": 1,
"no-nested-ternary": 0,
"no-empty": 0,
"no-constant-condition": 0,
"no-alert": 0,
"no-console": 0,
"no-continue": 0,
"no-underscore-dangle": 0,
"strict": [2, "global"],
"no-multiple-empty-lines": 0,
"no-restricted-syntax": [
0,
{
"selector": "ForInStatement"
},
{
"selector": "ForOfStatement"
}
],
"camelcase": [2, { "properties": "never" }],

"prettier/prettier": ["error"],
"prettier/prettier": ["error"],

"sonarjs/prefer-immediate-return": 0,
"sonarjs/prefer-immediate-return": 0,

"jsdoc/check-alignment": 1,
"jsdoc/check-indentation": 1,
"jsdoc/check-line-alignment": 1,
"jsdoc/check-param-names": 1,
"jsdoc/check-syntax": 1,
"jsdoc/check-tag-names": 1,
"jsdoc/check-types": 1,
"jsdoc/check-values": 1,
"jsdoc/empty-tags": 1,
"jsdoc/newline-after-description": 1,
"jsdoc/no-bad-blocks": 1,
"jsdoc/no-undefined-types": 1,
"jsdoc/require-description": 1,
"jsdoc/require-description-complete-sentence": 1,
"jsdoc/require-hyphen-before-param-description": 1,
"jsdoc/require-jsdoc": 1,
"jsdoc/require-param": 1,
"jsdoc/require-param-description": 1,
"jsdoc/require-param-name": 1,
"jsdoc/require-param-type": 1,
"jsdoc/require-returns": 1,
"jsdoc/require-returns-check": 1,
"jsdoc/require-returns-description": 1,
"jsdoc/require-returns-type": 1,
"jsdoc/require-throws": 1,
"jsdoc/require-yields": 1,
"jsdoc/require-yields-check": 1,
"jsdoc/valid-types": 1
}
"jsdoc/check-alignment": 1,
"jsdoc/check-indentation": 1,
"jsdoc/check-line-alignment": 1,
"jsdoc/check-param-names": 1,
"jsdoc/check-syntax": 1,
"jsdoc/check-tag-names": 1,
"jsdoc/check-types": 1,
"jsdoc/check-values": 1,
"jsdoc/empty-tags": 1,
"jsdoc/newline-after-description": 1,
"jsdoc/no-bad-blocks": 1,
"jsdoc/no-undefined-types": 1,
"jsdoc/require-description": 1,
"jsdoc/require-description-complete-sentence": 1,
"jsdoc/require-hyphen-before-param-description": 1,
"jsdoc/require-jsdoc": 1,
"jsdoc/require-param": 1,
"jsdoc/require-param-description": 1,
"jsdoc/require-param-name": 1,
"jsdoc/require-param-type": 1,
"jsdoc/require-returns": 1,
"jsdoc/require-returns-check": 1,
"jsdoc/require-returns-description": 1,
"jsdoc/require-returns-type": 1,
"jsdoc/require-throws": 1,
"jsdoc/require-yields": 1,
"jsdoc/require-yields-check": 1,
"jsdoc/valid-types": 1
}
}
4 changes: 1 addition & 3 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- run: npm install

- run: npm run format:check

- run: npm run lint:ls
- run: npm run lint:md
- run: npm run lint:js
Loading