Support for building under Linux #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when will this be added |
HackerPoet
requested changes
Mar 20, 2020
| void InitGLObjects(); | ||
| void DestroyGLObjects(); | ||
| void SetupInputs(); | ||
| void ConfineCursor(); | ||
| void ToggleFullscreen(); | ||
| int EnterMessageLoop(); | ||
| void PeriodicRender(int64_t cur_ticks); | ||
| void SwapBuffers(); |
There was a problem hiding this comment.
SwapBuffers is a Windows API function, this needs to be moved inside the Linux ifdef below to get this compiling on Windows.
| void InitGLObjects(); | ||
| void DestroyGLObjects(); | ||
| void SetupInputs(); | ||
| void ConfineCursor(); | ||
| void ToggleFullscreen(); | ||
| int EnterMessageLoop(); | ||
| void PeriodicRender(int64_t cur_ticks); |
There was a problem hiding this comment.
cur_ticks must be passed by reference here because it's modified in the method. Without that, it's running at a hyper-speed framerate.
|
Maybe it would be better to use CMake? |
|
When I run it, it just gives me a white screen. |
|
if #32 supersedes this pr, why not close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the following code allows building and running this cute little engine under Linux (using SDL2 as backend). Some features are not yet there (fullscreen switching, cursor confining), I plan to add them asap. Please merge if you wish! :-)