Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic refax: new rules for the receiver buffer and TSBPD #2527

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Logic refax: new rules for the receiver buffer and TSBPD #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
496e6a7
Exported fragment to a separate function
Sep 22, 2022
03214ff
Applied changes from PR 2467-before merging
Sep 30, 2022
96e92dd
Adjusted to the latest changes in the group branch, per changes in ma…
Oct 25, 2022
bdc6fff
Updated and post-fixed
Oct 25, 2022
a68d5cf
Updated for latest master
Oct 26, 2022
d2d1c90
Merge branch 'master' into dev-processdata-refax
Oct 26, 2022
89e927f
Added lacking fix for AEAD
Oct 26, 2022
a56c84d
Fixed: block static variable that might be unused when no logging (tr…
Oct 27, 2022
0168c5e
Fixed after PR comments
Nov 1, 2022
870509f
Renamed getPacketPTS. Moved call to obtain PTS under belated condition
Nov 3, 2022
9f5174c
Merge branch 'dev-processdata-refax' into dev-refax-buffer-tsbpd-trig…
Nov 7, 2022
652e35d
Applied changes for improved TSBPD and receiver buffer
Nov 7, 2022
6295cb9
Updated and fixed
Nov 8, 2022
36c1f67
Updated usage of shortcuts and new names
Nov 8, 2022
1fbd754
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
Nov 9, 2022
478ca41
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
Nov 10, 2022
8335cbe
Fixed some logs formatting
ethouris Nov 10, 2022
df46c57
Updated to latest upstream
Nov 23, 2022
1df7e40
Updated and fixed
Dec 6, 2022
0b515e8
Updated
Dec 23, 2022
f636ce7
Updated and fixed
Feb 22, 2023
ae914e5
Merged and stabilized
Sep 19, 2023
519cb7e
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
Sep 19, 2023
4bb7b47
Added mutex spec to a function
Sep 19, 2023
d179878
Added more thread check entries
Sep 19, 2023
94fb676
Updated to latest upstream
Feb 15, 2024
8ad69ed
Fixed a suggested uninitialized variable
Feb 15, 2024
bbced79
Renamed eclipsed variable
Feb 16, 2024
5136ca2
Added doxy description for some functions. Applied NonOrder in names …
Feb 16, 2024
f6e0271
Removed wrong fix. Fixed C++11 style initialization of PacketInfo
Feb 16, 2024
072a8c4
Refax: CRcvBuffer extracted some parts of insert() to separate functions
Feb 16, 2024
1830e3a
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
Feb 22, 2024
283021e
Apply suggestions from code review
ethouris Feb 28, 2024
b969a83
Remaining post-review fixes
Feb 28, 2024
df237d6
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
Feb 29, 2024
d8f485a
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
Mar 11, 2024
d9f079a
Turned integer-based values to strong types. CHECKPOINT: tests passed
Jun 3, 2024
ab469d6
Fixed previous problems with receiver buffer
Jun 10, 2024
a2b1b44
First working version with end/drop as offset
ethouris Jun 17, 2024
ff16e68
Blocked development support types and fixed the test
Jun 17, 2024
1f6ac3d
Updated to latest upstream
Jun 18, 2024
fa70fda
Merged changes
Jun 18, 2024
1bf93ff
Cleanup of the commented-out code
Jun 18, 2024
f4f22ba
Cleaning up other temporary development entries
Jun 18, 2024
0a88fdf
Updated and fixed
Aug 14, 2024
74a27ed
Updated and fixed
Aug 29, 2024
cb00cce
Added option to disable test discovery (off by default)
Sep 3, 2024
5bc71e9
BUGFIX: the buffer info extraction function wasn't mutex-protected
Sep 4, 2024
6bbd31d
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
Dec 18, 2024
5cba144
Reworked attributes. Put inc() method of CSeqNo in use for clarity
Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change of CMakeLists.txt can be moved to a separate PR. Plus corresponding changes to build options are needed: new build option DISABLE_UNITTESTS_DISCOVERY

Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ option(ENABLE_PKTINFO "Enable using IP_PKTINFO to allow the listener extracting
option(ENABLE_RELATIVE_LIBPATH "Should application contain relative library paths, like ../lib" OFF)
option(ENABLE_GETNAMEINFO "In-logs sockaddr-to-string should do rev-dns" OFF)
option(ENABLE_UNITTESTS "Enable unit tests" OFF)
option(DISABLE_UNITTESTS_DISCOVERY "Do not discover unit tests when enabled" OFF)
option(ENABLE_ENCRYPTION "Enable encryption in SRT" ON)
option(ENABLE_AEAD_API_PREVIEW "Enable AEAD API preview in SRT" Off)
option(ENABLE_MAXREXMITBW "Enable SRTO_MAXREXMITBW (v1.6.0 API preview)" Off)
Expand Down Expand Up @@ -1542,7 +1543,9 @@ if (ENABLE_UNITTESTS AND ENABLE_CXX11)
#set_tests_properties(test-srt PROPERTIES RUN_SERIAL TRUE)
else()
set_tests_properties(${tests_srt} PROPERTIES RUN_SERIAL TRUE)
gtest_discover_tests(test-srt)
if (NOT DISABLE_UNITTESTS_DISCOVERY)
gtest_discover_tests(test-srt)
endif()
endif()

enable_testing()
Expand Down
3 changes: 2 additions & 1 deletion srtcore/api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ class CUDTSocket
return m_iBusy;
}


// XXX Controversial as to whether it should be guarded by this lock.
// It is used in many places without the lock, and it is also atomic.
SRT_ATTR_GUARDED_BY(m_ControlLock)
sync::atomic<SRT_SOCKSTATUS> m_Status; //< current socket state

Expand Down
Loading
Loading