Fix extra ack being sent after a connection is established #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an initialization of m_bBufferWasFull to false when starting a connection
ethouris
reviewed
Dec 11, 2023
Fix guidelines for minimum in flight packets computation
|
Ah, forgot one thing: if you set this to true in |
|
That's true, I was focusing on the issue on the transmitter side and forgot about the receiver |
maxsharabayko
added
Type: Bug
yomnes0
changed the title
maxsharabayko
requested changes
Dec 18, 2023
There was a problem hiding this comment.
The startConnect function is used by a caller (and probably by a rendezvous), but not by a listener. The variable stays uninitialized for a listener.
@yomnes0 please use the common place for initialization where all other CUDT member variables are initialized.
Co-authored-by: Maxim Sharabayko <[email protected]>
maxsharabayko
approved these changes
Dec 20, 2023
maxsharabayko
pushed a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
…n#2832) (uninitialized variable).
maxsharabayko
pushed a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
…n#2832) (uninitialized variable).
maxsharabayko
pushed a commit
that referenced
this pull request
Apr 29, 2024
(uninitialized variable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an initialization of m_bBufferWasFull to false when starting a connection. This will prevent an extra ack from being sent right after the handshake.
Fixes #2829.