Cuberoot: Apply first iteration explicitly #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying the first iteration explicitly appears to speed up the cuberoot function by a bit over 20%: Before: Halley Final: 0.14174999999999999 After: Halley Final: 0.11080000000000001 There is an assumption that compilers will precompute the constants like `0.7 * (0.7)**3`, and that all will do so in the same manner.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## Halley_cuberoot #11 +/- ##
===================================================
- Coverage 42.97% 37.19% -5.79%
===================================================
Files 41 271 +230
Lines 5028 80346 +75318
Branches 953 14982 +14029
===================================================
+ Hits 2161 29888 +27727
- Misses 2684 44902 +42218
- Partials 183 5556 +5373 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
merged commit d670263
into
Hallberg-NOAA:Halley_cuberoot
12 checks passed
marshallward
added a commit
that referenced
this pull request
Jan 26, 2024
Applying the first iteration explicitly appears to speed up the cuberoot function by a bit over 20%: Before: Halley Final: 0.14174999999999999 After: Halley Final: 0.11080000000000001 There is an assumption that compilers will precompute the constants like `0.7 * (0.7)**3`, and that all will do so in the same manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the first iteration explicitly appears to speed up the cuberoot function by a bit over 20%:
Before:
Halley Final: 0.14174999999999999
After:
Halley Final: 0.11080000000000001
There is an assumption that compilers will precompute the constants like
0.7 * (0.7)**3, and that all will do so in the same manner.