-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hotkey.lua: add isActive #3608
base: master
Are you sure you want to change the base?
Update hotkey.lua: add isActive #3608
Conversation
add isActive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']
TODO:
|
i can not see why the test are failing :( |
@muescha ignore the CI tests, they're horribly broken at the moment. I think this feature makes sense to add, so if you'd like to go ahead with it, I like your idea that an |
did you mean "hiding implementation" like this in 7e389a0
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3608 +/- ##
==========================================
+ Coverage 27.61% 27.63% +0.01%
==========================================
Files 180 191 +11
Lines 36181 43465 +7284
==========================================
+ Hits 9993 12012 +2019
- Misses 26188 31453 +5265 |
add isActive
See: