Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed websocket support in hs.httpserver:start() #3665

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

latenitefilms
Copy link
Contributor

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@latenitefilms latenitefilms added the pr-fix Pull Request implementing a bug fix label Aug 10, 2024
extensions/httpserver/libhttpserver.m Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.70%. Comparing base (ec9a8ea) to head (45eaf01).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3665      +/-   ##
==========================================
+ Coverage   27.65%   27.70%   +0.04%     
==========================================
  Files         191      191              
  Lines       43472    43528      +56     
==========================================
+ Hits        12023    12059      +36     
- Misses      31449    31469      +20     

@cmsj cmsj merged commit fa58fd4 into master Nov 12, 2024
3 of 5 checks passed
@cmsj cmsj deleted the issue/3468-fix-websocket-support-in-server-start branch November 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is an HTTP callback required if I only want a WebSocket server in hs.httpserver?
2 participants