Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.paths under userruntime w/ unexpanded tilde #3703

Conversation

habibalamin
Copy link
Contributor

Lua doesn't automatically expand tildes to $HOME, as this code seems to assume.

Fix #3518

I didn't mean to close #3702.

Lua doesn't automatically expand tildes to `$HOME`, as this code seems
to assume.

Fix Hammerspoon#3518
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@cmsj cmsj added the pr-fix Pull Request implementing a bug fix label Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.99%. Comparing base (08cb813) to head (80562d7).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3703      +/-   ##
==========================================
- Coverage   27.67%   26.99%   -0.69%     
==========================================
  Files         191      191              
  Lines       43532    51396    +7864     
==========================================
+ Hits        12049    13875    +1826     
- Misses      31483    37521    +6038     

@cmsj cmsj merged commit dbfd067 into Hammerspoon:master Nov 12, 2024
4 of 7 checks passed
@cmsj
Copy link
Member

cmsj commented Nov 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tilde in userruntime variable used in package.path not expanded
2 participants