Don't try to read nullable types from ADO.NET directly

HangfireIO · Dec 16, 2024 · d0d6cc8 · d0d6cc8
1 parent fbda21a
commit d0d6cc8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Hangfire.SqlServer/DbCommandExtensions.cs b/src/Hangfire.SqlServer/DbCommandExtensions.cs
@@ -112,6 +112,21 @@ public static DbCommand AddExpandedParameter<T>(
             return command;
         }
 
+        public static T GetParameterValue<T>([NotNull] this DbParameter parameter)
+        {
+            if (parameter == null) throw new ArgumentNullException(nameof(parameter));
+
+            switch (parameter.Value)
+            {
+                case null or DBNull: return default;
+                case T typed: return typed;
+                default:
+                    var type = typeof(T);
+                    type = Nullable.GetUnderlyingType(type) ?? type;
+                    return (T)Convert.ChangeType(parameter.Value, type, CultureInfo.InvariantCulture);                    
+            }
+        }
+
         private static DbParameter AddParameterInternal(
             DbCommand command,
             string parameterName,

diff --git a/src/Hangfire.SqlServer/SqlServerWriteOnlyTransaction.cs b/src/Hangfire.SqlServer/SqlServerWriteOnlyTransaction.cs
@@ -101,7 +101,7 @@ public override void Commit()
 
                         foreach (var lockCommand in ctx._lockCommands)
                         {
-                            var releaseResult = (int?) lockCommand.Item2.Value;
+                            var releaseResult = lockCommand.Item2.GetParameterValue<int?>();
                             if (releaseResult.HasValue && releaseResult.Value < 0)
                             {
                                 throw new SqlServerDistributedLockException($"Could not release a lock on the resource '{lockCommand.Item3}': Server returned the '{releaseResult}' error.");