Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple account configurations #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aschempp
Copy link
Collaborator

@aschempp aschempp commented Mar 5, 2019

As promised, this is the first PR extracted from #18

The changes are fairly simple: Instead of just one account configuration, you can have an array of them. Existing configurations will automatically be migrated/merge, so they still work. Let me know if you're okay with that general concept and I'll add some unit tests as well.

/cc @ddonnini @Nyholm

@aschempp aschempp marked this pull request as ready for review March 5, 2019 12:13
@aschempp
Copy link
Collaborator Author

@ddonnini @Nyholm any feedback on this? I think the failing tests are not really related to the PR, the travis tests seem widely outdated (Symfony 2 + PHP 5 😂 )

@ddonnini
Copy link
Contributor

Hi @aschempp, no news, if you would like to take a look at our fork we built something more, can't help you here :(
https://github.com/r-everse/GoogleApiBundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants