-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mod] Hyrule Warriors-style Link #665
base: develop
Are you sure you want to change the base?
Conversation
@OtherBlue nice work! Is your intent to have this merged upstream or just have a place to host it? If the latter you can follow the |
Personally, I would love to see this making it's way to the main build Good job buddy! |
I'm thinking of opening the PR to the main build now Wasn't the original intention but it's probably more convenient anyway Just gotta figure out why clang-format is failing ig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Just a couple things
@@ -29,6 +29,7 @@ void InitEnhancements() { | |||
|
|||
// Graphics | |||
RegisterDisableBlackBars(); | |||
RegisterHWStyledLink(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be easier to understand what this is doing if we write it out in full
RegisterHWStyledLink(); | |
RegisterHyruleWarriorsStyledLink(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, absolutely, just old habits still sticking around haha
Matrix_RotateYS(14563, MTXMODE_APPLY); | ||
Matrix_RotateZS(-4854, MTXMODE_APPLY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matrix_RotateYS and Matrix_RotateZS use 'binangs' (binary angles). Would it be alright to write this as hex?
Alternatively, write it in degrees and use the DEG_TO_BINANG(angle) macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh these first values were put in there by Proxy, I'll look into converting them tho
Alrighty, final(?) changes made |
Adds an option to place the Keaton and Fierce Deity masks similarly to how they are placed on Young Link in Hyrule Warriors once they are acquired in-game.
Branches off #537 for the "OnPlayerPostLimbDraw" hook
Build Artifacts