Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make sword beams work on any enemy #682

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    5d7f2fd View commit details
    Browse the repository at this point in the history
  2. Apply arrow effect to FD sword beams in hook

    Add separate variable for FD sword beams on regular enemies
    Eblo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    39eec15 View commit details
    Browse the repository at this point in the history
  3. Add damage multiplier and effect hooks

    Use those for Fierce Deity sword beam stuff
    Add DamageAndEffectHookInfo struct to pass multiple fields into hooks
    Use ActorInit hook on sword beams for the arrow damage effect
    Eblo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c823252 View commit details
    Browse the repository at this point in the history
  4. Add light arrow effect to sword beams

    Actually pass in the DamageAndEffectHookInfo pointer for the damage effect hook
    Add more clarification within FDA enhancement comments
    Eblo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    52c2b5c View commit details
    Browse the repository at this point in the history
  5. Overhaul how sword beams work on regular enemies

    Revamp how sword beam handling works with Fierce Deity Anywhere
    Remove light arrow damage flag and instead make sword beams always collide with actors
    Give sword beams the light arrow effect if they do not already have one defined
    Draw blue light orbs effect for sword beams using the light orbs effect
    Add special sword beam damage effect for Big Octos since they're unique with drawing damage effects
    Eblo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5491ea4 View commit details
    Browse the repository at this point in the history
  6. Use variadic args for damage hooks

    Use va_arg for FierceDeityAnywhere arguments
    Remove now-obsolete DamageAndEffectHookInfo struct
    Eblo committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b6fb24f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    73dbe6b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Streamline sword beam collision

    Only override CollisionCheck_NoSharedFlags if the toucher belongs to a sword beam
    Condense FierceDeityAnywhere static variables to one for the actor being drawn
    Eblo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    198e8cd View commit details
    Browse the repository at this point in the history