Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cheat] Allow Elegy of Emptiness anywhere #712

Merged

Conversation

Eblo
Copy link
Contributor

@Eblo Eblo commented Jun 24, 2024

Extremely straightforward, this cheat just circumvents the scene check when playing the song.

image

Build Artifacts

mckinlee pushed a commit to mckinlee/2ship2harkinian that referenced this pull request Sep 23, 2024
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only point of feedback would be on the VB name, it's not horrible but still reads odd to me "Should elegy in ikana only?"

Otherwise just needs updating to modern menu and headers LGTM

@Eblo Eblo force-pushed the elegy-of-emptiness-anywhere branch from ab2812a to 7115a69 Compare October 9, 2024 02:40
@Eblo
Copy link
Contributor Author

Eblo commented Oct 9, 2024

I applied those changes. Agreed on the VB name, so I changed it to VB_ELEGY_CHECK_SCENE.

I'm not sure why generating the o2r failed in the PR. It succeeded in my fork's run. I don't have the authority to clear cache or re-run the PR job here, but I'm assuming it was a fluke.

Removed redundant null from Elegy scene check
Moved ElegyAnywhere enhancement's menu order
@Eblo Eblo force-pushed the elegy-of-emptiness-anywhere branch 2 times, most recently from ddab40f to aefce42 Compare October 10, 2024 03:00
@Eblo Eblo force-pushed the elegy-of-emptiness-anywhere branch from aefce42 to 30b3d52 Compare October 10, 2024 03:02
@garrettjoecox garrettjoecox merged commit 0b16bce into HarbourMasters:develop Oct 10, 2024
5 checks passed
@Eblo Eblo deleted the elegy-of-emptiness-anywhere branch October 10, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants