Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Skip the scarecrow song #723

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Eblo
Copy link
Contributor

@Eblo Eblo commented Jun 27, 2024

Much like the setting in SoH, this allows Link to summon Pierre just by pulling out his instrument near a spawn point. This incidentally means that the 3-day cycle reset won't impact Link's ability to call Pierre.

2024-06-27.08-27-40.mp4

If and when entrance randomizer becomes a thing, this will have to be taken into consideration, as the song is typically gated by being able to reach Pierre in Clock Town.

Build Artifacts

mckinlee pushed a commit to mckinlee/2ship2harkinian that referenced this pull request Sep 23, 2024
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a modern menu entry and moving the header over to using the cycle.h

@Eblo
Copy link
Contributor Author

Eblo commented Oct 10, 2024

LGTM, just needs a modern menu entry and moving the header over to using the cycle.h

Done, but moved to Songs.h

@garrettjoecox garrettjoecox merged commit 3ebfdb3 into HarbourMasters:develop Oct 10, 2024
5 checks passed
@Eblo Eblo deleted the skip-scarecrow-song branch October 10, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants