Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement?] Disable Takkuri Steal #776

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mckinlee
Copy link
Contributor

@mckinlee mckinlee commented Sep 23, 2024

It just simply returns false in func_80C10B0C if the the checkbox is checked. Nothing fancy.

Put it in Time Savers section for now, not sure where this fits best.

Build Artifacts

Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a new "difficulty options" section similar to SoH's might make sense to house this?

Additionally we should use the VB pattern to prevent this behavior. I would suggest adding a new VB enum for GI_VB_THIEF_BIRD_STEAL, and within thiefbird.c around line 588 wrap the (Rand_ZeroOne() < 0.5f) with a GameInteractor_Should. This will allow us to rely on the vanilla condition (50% randomness) and allow us to override it when we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants