Implemented OS keyring storage for credential file password #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the need for the password to be entered every time the bot starts. As long as a user doesn't lose control of their physical computer
DakkJaniels
approved these changes
Dec 22, 2020
|
Can you guys rerun the action auto build to check the why is it not accepting this? the error output is expired. |
|
the only thing it tells us if the code doesn't conform to black formatting. It has nothing to do with if the code is functional. |
|
This is the first time I hear about black formatting. I am reading their page right now, TIL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the need for the password to be entered every time the bot starts. As long as a user doesn't lose control of their physical computer and their local account password, it seems as safe as entering the text at startup and still prevents any copy/paste credential incidents from the community.