Skip to content

Commit

Permalink
FIX(a11y): Improve accessiblity of the edit shortcut dialog
Browse files Browse the repository at this point in the history
  • Loading branch information
Hartmnt committed Apr 20, 2023
1 parent 81008dd commit d83924e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/mumble/GlobalShortcutButtons.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,12 @@ void GlobalShortcutButtons::toggleCapture(const bool enabled) {
GlobalShortcutEngine::engine->resetMap();
connect(GlobalShortcutEngine::engine, &GlobalShortcutEngine::buttonPressed, this,
&GlobalShortcutButtons::updateButtons);
m_ui->addButton->setText(QObject::tr("Listening for input"));
} else {
disconnect(GlobalShortcutEngine::engine, &GlobalShortcutEngine::buttonPressed, this,
&GlobalShortcutButtons::updateButtons);
removeEventFilter(this);
m_ui->addButton->setText(QObject::tr("Add"));
}
}

Expand Down
6 changes: 6 additions & 0 deletions src/mumble/GlobalShortcutButtons.ui
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@
<property name="whatsThis">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Starts the capture process: all buttons you press will be added to the tree.&lt;/p&gt;&lt;p&gt;Once all buttons are released, the capture process stops automatically.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="accessibleDescription">
<string>Toggling this button will make the application listen for a shortcut. Once the shortcut is entered, the application stops listening for a shortcut. Multiple shortcuts can be assigned to the current action. Navigate to the shortcut list above to review the shortcuts currently assigned to the current action.</string>
</property>
<property name="text">
<string>Add</string>
</property>
Expand All @@ -58,6 +61,9 @@
<property name="toolTip">
<string>Remove the currently selected items</string>
</property>
<property name="accessibleDescription">
<string>This button will remove the selected shortcut for the current action. Note that you will have to select a shortcut from the list above first before this button has any effect.</string>
</property>
<property name="text">
<string>Remove</string>
</property>
Expand Down

0 comments on commit d83924e

Please sign in to comment.