Rename "CreateNewGame" to "GameIsFull" #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some extra conditions to ensure that the key value reading is correct regardless of user's keyboard language. With the use of event.code.
Added some extra code to the getKeyFromInputEvent function so keyboard events are read correctly and regardless of user's keyboard language.
Update life_preserver.svg
Game started sound notification (If page/document isn't focused)
* Bug fix on inputManager.ts (keyboard events) Added some extra conditions to ensure that the key value reading is correct regardless of user's keyboard language. With the use of event.code. * Update inputManager.ts * Bug fix on inputManager.ts (keyboard events) Added some extra code to the getKeyFromInputEvent function so keyboard events are read correctly and regardless of user's keyboard language. * Update inputManager.ts * Added halloween light and dark pumpkin svgs * Wrong branch lol * Wrong branch lol * Team menu now has blurry backdrop and blocks interaction * Changed blurring to brightness (darker). * Fixed the little lag with the backdrop filter change --------- Co-authored-by: papas24 <[email protected]>
* Bug fix on inputManager.ts (keyboard events) Added some extra conditions to ensure that the key value reading is correct regardless of user's keyboard language. With the use of event.code. * Update inputManager.ts * Bug fix on inputManager.ts (keyboard events) Added some extra code to the getKeyFromInputEvent function so keyboard events are read correctly and regardless of user's keyboard language. * Update inputManager.ts * Added halloween light and dark pumpkin svgs * Wrong branch lol * Wrong branch lol * Bug Fix: Kill feed acting weird while the "big" map is opened. * Update minimap.ts --------- Co-authored-by: papas24 <[email protected]> Co-authored-by: Henry Sanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming the "CreateNewGame" worker message type to "GameIsFull" to be more descriptive and give information about the state of the worker thread, rather than the intended action.