Unfinished controller support, please follow comments

[Arman-AIi]

note: this has only been tested on stadia controller
changes are only in client > src > scripts > managers > inputManager.ts

[Compositr]

Is there any way to do this without having a ton of gamepadX or whatever vars?

[Arman-AIi]

You can condense them into a few lines but you need them to use all controller buttons

[tomatopotato17265]

Controls recommendations:

B: drop items (press to scroll between items, press and hold to actually drop)
X: map
Y: Special emotes (ammo request, medkit request, etc.)

idk how this works but if you can take advantage of the mini-touchpad on ps4 and ps5 controllers for a mini cursor some ppl might like that

[Arman-AIi]

Controls recommendations:

B: drop items (press to scroll between items, press and hold to actually drop) X: map Y: Special emotes (ammo request, medkit request, etc.)

idk how this works but if you can take advantage of the mini-touchpad on ps4 and ps5 controllers for a mini cursor some ppl might like that

how will Y for special emotes work exactly

[tomatopotato17265]

Controls recommendations:

B: drop items (press to scroll between items, press and hold to actually drop) X: map Y: Special emotes (ammo request, medkit request, etc.)

idk how this works but if you can take advantage of the mini-touchpad on ps4 and ps5 controllers for a mini cursor some ppl might like that

how will Y for special emotes work exactly

You hold down Y while using the D-pad. This system works similar to mobile special emotes: you toggle that cellular tower thing then select the emotes.

[Arman-AIi]

Controls recommendations:

B: drop items (press to scroll between items, press and hold to actually drop) X: map Y: Special emotes (ammo request, medkit request, etc.)

idk how this works but if you can take advantage of the mini-touchpad on ps4 and ps5 controllers for a mini cursor some ppl might like that

how will Y for special emotes work exactly

You hold down Y while using the D-pad. This system works similar to mobile special emotes: you toggle that cellular tower thing then select the emotes.

Sounds good. The primary goal is to have bindable controller buttons and working analog sticks, defaults are just a nice-to-have. We also must have a controller-navigable UI

[tomatopotato17265]

Controls recommendations:

B: drop items (press to scroll between items, press and hold to actually drop) X: map Y: Special emotes (ammo request, medkit request, etc.)

idk how this works but if you can take advantage of the mini-touchpad on ps4 and ps5 controllers for a mini cursor some ppl might like that

how will Y for special emotes work exactly

You hold down Y while using the D-pad. This system works similar to mobile special emotes: you toggle that cellular tower thing then select the emotes.

Sounds good. The primary goal is to have bindable controller buttons and working analog sticks, defaults are just a nice-to-have. We also must have a controller-navigable UI

We should take things one at a time. Suroi for console doesn't exist yet so we don't need to worry about controller-navigable UI. I say we first add the functionality with default controls, then add the ability to customized bindings. Controller-navigable UI is something we don't have to worry about until we make Suroi for Xbox, PlayStation, Nintendo Switch, or other controller-based platform.

[kenos1]

this easily has to be one of the most atrocious pieces of code i've ever seen from a suroi dev

how hard is it to not repeat yourself and do something like

const GamepadButtonMap = ["GamepadA", ...] // truncated for demo purposes

if (event instanceof GamepadEvent) {
  input = GamepadButtonMap.find((_, i) => event.gamepad.buttons[i].pressed) ?? "GamepadUnknown"
}

[kenos1]

me when PIXI.Application.ticker

[Compositr]

We need to make this far, far more concise. Also what the hell is that gameLoop function... (see Kenos' comment)

[kenos1]

Also please read https://developer.mozilla.org/en-US/docs/Web/API/Gamepad/buttons as you are missing critical information lol

[kenos1]

oh yeah by the way to anyone whos reading patch-notes channel i am homeless and also the fbi is after me

[kenos1]

oh yeah by the way to anyone whos reading patch-notes channel i am homeless and also the fbi is after me

[Arman-AIi]

Also please read https://developer.mozilla.org/en-US/docs/Web/API/Gamepad/buttons as you are missing critical information lol

This is the guide I am using

[leia-uwu]

hiiii suroi patch-notes channel I'm totally original and not copying kenos
anyways LGTM should merge asap and push to production 👍

[Arman-AIi]

hiiii suroi patch-notes channel I'm totally original and not copying kenos anyways LGTM should merge asap and push to production 👍

I agree with this information

[Arman-AIi]

We need to make this far, far more concise. Also what the hell is that gameLoop function... (see Kenos' comment)

The requested changes have been fully completed sir.

also how did I wake up leia and kenos 💀 💀

[leia-uwu]

also how did I wake up leia and kenos 💀 💀

kenos pinged me to make fun of your code

[ei-pi]

kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill kill

[1092384]

You can condense them into a few lines but you need them to use all controller buttons

i've decided you're a furry

[kenos1]

[Arman-AIi]

I already changed it why so mean 😢

[tomatopotato17265]

While you're decluttering the code, pls add comments for noobs like me :)

[ersek-huba]

This is the funniest PR comment section, I've ever seen so far (after the Chinese John Cena one (including the Linux PR)).

[Arman-AIi]

new commit, fixed issue where the buttons just refused to register, working and tested