Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #41: Fix MIDDLEWARE_CLASSES error with runserver #42

Merged

Conversation

gh640
Copy link
Contributor

@gh640 gh640 commented Feb 28, 2018

This is a small PR to address #41.

I read the contributing guide ( https://github.com/HassenPy/django-pdb/blob/master/CONTRIBUTING.md )but I couldn't judge if I may send PR or not in this case. I'm sorry if I disturb you with this PR.

After applying this change, I could use this package with Django 2.0.2.

Also, (in #40 ) I found you are planning to rewrite whole code. If you don't take PR for now to rewrite the project, please don't hesitate to reject this.

Also, I'm planning to rewrite the whole project,

Thank you in advance.

@HassenPy
Copy link
Owner

HassenPy commented Feb 28, 2018

Welcome @gh640 and thanks, i already started refactoring the project, not sure when i ll finish thou, i inherited the contribution guide and changed it locally, i ll try to update the project asap.

hmm that seems to fix the error but it doesn't seem to fix the --pdb or --ipdb arguments not being discovered, from what i remember the whole management module needs rewriting, i can merge that for now to silence the error, however i'm still unable to reproduce the error, i tried with the same versions as you did but didn't get the error.

@HassenPy
Copy link
Owner

HassenPy commented Feb 28, 2018

probably failing to reproduce since the pdb/ipdb arguments are not being picked, i ll try to finish the refactoring asap, i already have some work done but still figuring the best way to keep this project testable, i thought about a branch for every major version and the master branch will always be the latest version after a Django breaking change to Middleware, management commands or template tags.

@HassenPy
Copy link
Owner

HassenPy commented Feb 28, 2018

if anyone is in urgent need for this you can install @gh640's version with:
pip install git+https://github.com/gh640/django-pdb

@gh640
Copy link
Contributor Author

gh640 commented Feb 28, 2018

@HassenPy thank you for you response and taking the time to review the PR.

Actually I tested the function with pdb GET parameter which is different from the case you tested. As with the issue of option --pdb and --ipdb you told, I'll try investigating them.

Anyway, thank you for all of your work!

@HassenPy HassenPy merged commit 1652b7a into HassenPy:master Mar 1, 2018
@gh640
Copy link
Contributor Author

gh640 commented Mar 2, 2018

@HassenPy thank you for processing this!

I tested the option --pdb and --ipdb in my environment and it seems to work well... If I find any issue using this package, I'll let you know. Thank you for your swift and kind reaction :)

HassenPy added a commit that referenced this pull request May 4, 2018
…_error

Issue #41: Fix MIDDLEWARE_CLASSES error with `runserver`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants