feat: improve push notification opt-in modal #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexruzenhack
changed the title
andreabadesso
requested changes
Apr 10, 2024
| onPress={onEnablePushNotifications} | ||
| /> | ||
| <ModalBase.DiscreteButton | ||
| title={t`No, not now`} |
There was a problem hiding this comment.
Are we missing translations for this?
There was a problem hiding this comment.
Also, I think line numbers changed, we should update the pot
|
From UX and UX Writing side is approved. :) |
alexruzenhack
force-pushed
the
feat/nano-contract-transaction-details-component
branch
from
a0caced to
f823c2b
Compare
alexruzenhack
force-pushed
the
feat/nano-contract-transaction-details-component
branch
3 times, most recently
from
a946e8f to
12d5cc2
Compare
alexruzenhack
force-pushed
the
feat/nano-contract-transaction-details-component
branch
3 times, most recently
from
34fffb2 to
a9caff1
Compare
Base automatically changed from
feat/nano-contract-transaction-details-component
to
master
June 14, 2024 02:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #429
Acceptance Criteria
Opt-in
Warning
It depends on:
Security Checklist