Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: current-project to 1.0.1 #497

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

alexruzenhack
Copy link
Contributor

Acceptance Criteria

  • This bump allows the same iOS version to be published

Checklist

  • Make sure you updated the CURRENT_PROJECT_VERSION with the appropriate release-candidate version in ios/HathorMobile.xcodeproj/project.pbxproj
  • Make sure you updated the MARKETING_VERSION with the appropriate version in ios/HathorMobile.xcodeproj/project.pbxproj
  • Make sure you updated the version attribute in package.json
  • Make sure you updated the version attribute in package-lock.json
  • Make sure you incremented the versionCode attribute in android/app/build.gradle
  • Make sure you updated the versionName with the appropriate version, including the release candidate number in android/app/build.gradle

@alexruzenhack alexruzenhack requested a review from tuliomir June 11, 2024 16:28
@alexruzenhack alexruzenhack self-assigned this Jun 11, 2024
@@ -512,7 +512,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = HathorMobile/HathorMobile.entitlements;
CURRENT_PROJECT_VERSION = 1.0.0;
CURRENT_PROJECT_VERSION = 1.0.1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I'm not sure this would work. The way we use the PROJECT_VERSION property is only by manipulating the major and versions: one for each release candidate version. For example: rc.4 would have a project version 0.4.0.

When we have a stable release we use the 1.0.0.
So in this case the 1.0.1 would have no meaning and should not be used.

My suggestion is that we update the full application to a new patch: v0.27.1. This would revert the CURRENT_PROJECT_VERSION to 1.0.0 as it will be a new stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants