Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logging and rejecting invalid blueprint errors #536

Open
wants to merge 85 commits into
base: master
Choose a base branch
from
Open

feat: logging and rejecting invalid blueprint errors #536

wants to merge 85 commits into from

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Aug 21, 2024 •
edited
Loading

Acceptance Criteria

  • We should handle the BluePrintNotFound error from the rpc-lib properly by rejecting the rpc request

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack @andreabadesso
feat: implement Nano Contract integration with Wallet Connect
1cb5aac
@alexruzenhack @andreabadesso
feat: adapt new nc tx to initialize, set result and withdrawal
9f48b97 
feat: make ncAddress react to firstAddress change
@alexruzenhack @andreabadesso
feat: make ncAddress react to firstAddress the right way
95629d7
@alexruzenhack @andreabadesso
feat: add name to method arguments
bc5f6ab
@alexruzenhack @andreabadesso
i18n: udpate files
aeb5717
@alexruzenhack @andreabadesso
i18n: update translations and fix some typos
37c91d2
@alexruzenhack @andreabadesso
review: apply suggestions and do some fixes
6aecd30
@alexruzenhack @andreabadesso
refactor: load of token details not refistered but used in actions
28b0b76
@alexruzenhack @andreabadesso
lint: comply with rules
dce9e41
@alexruzenhack @andreabadesso
chore: remove unused action
347ccf4
@alexruzenhack @andreabadesso
chore: add undeclared style
63da64e
@alexruzenhack @andreabadesso
refactor: walletConnect.tokens to unregisteredTokens
f3204e5
@alexruzenhack @andreabadesso
chore: remove unused actions, reducer and saga effect
d2e68fa
@alexruzenhack @andreabadesso
chore: improving feedback message
ca000ad
@alexruzenhack @andreabadesso
refactor: move requestTokens from walletConnect saga to tokens saga
a0e7ce2
@alexruzenhack @andreabadesso
refactor: rename effect requestTokens to requestUnregisteredTokens
079d9a6
@alexruzenhack @andreabadesso
feat: fire sentry error notification for method info not found
a4daab0
@alexruzenhack @andreabadesso
feat: improve title of Arguments component
c46b004
@alexruzenhack @andreabadesso
chore: remove blueprint info action and reducer
b8e03dd
@alexruzenhack @andreabadesso
feat: retrieve fallback arg entries when blueprint is loading
7974539
@alexruzenhack @andreabadesso
feat: add nft check to action token on Actions component
443e591
@alexruzenhack @andreabadesso
chore: apply suggestions and improve documentation on new nc tx request
ef847e7
@alexruzenhack @andreabadesso
lint: comply with rules
fc2f31e
@alexruzenhack @andreabadesso
fix: check if blueprintInfo is not null
df22c87
@alexruzenhack @andreabadesso
refactor: reanem style value to field
8484393
@alexruzenhack @andreabadesso
type: recursar
b647b3e
@alexruzenhack @andreabadesso
i18n: update translation files
21dc439
@alexruzenhack @andreabadesso
feat: add blueprint download to the tx loading flag and a redundancy
d32db25
@alexruzenhack @andreabadesso
fix: FeedbackContent margin style
c72b2ea 
Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.
@alexruzenhack @andreabadesso
lint: comply with rules
b2afb9e
@andreabadesso
feat: added log for sagas crash and max retries
3df12a8
@andreabadesso
fix: log being called incorrectly
81aeeeb
@andreabadesso
feat: logging when wallet-connect is initialzed
faa90bb
@andreabadesso
fix: added missing import
977cab7
@andreabadesso
fix: broken rebase fixes
296e951
@andreabadesso
chore: updated translations
639bf52
@andreabadesso
refactor: removed fuzzy translations
156d3b3
@andreabadesso
refactor: removed unused import on NanoContactTransactionHeader
6327d32
@andreabadesso
feat: logging error on root saga
6a8474b
@andreabadesso
chore: removed walletconnect libraries from package
7625ed7
@andreabadesso
feat: added hathor-rpc-handler from the deployed lib
d0e01e5
@andreabadesso
chore: changed CI version to 18x and 20x
5b5f7bb
@andreabadesso
chore: updated enable walletconnect script
1a9a566
@andreabadesso
refactor: removed error logging on NanoContractMethodArgs
a9f30c5
@andreabadesso
chore: removed local library from package-lock.json
3f087ab
@andreabadesso
refactor: removed unused option on PinScreen
b1213ce
@andreabadesso
fix: added missing import
3b0593b
@andreabadesso
chore: removed comment on pt-br texts
d372cb5
@andreabadesso
feat: logging and rejecting invalid blueprint errors
4ebda42
@andreabadesso andreabadesso self-assigned this Aug 21, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Aug 21, 2024
@andreabadesso andreabadesso mentioned this pull request Aug 21, 2024
Merged
1 task
alexruzenhack
alexruzenhack reviewed Aug 22, 2024
View reviewed changes
src/sagas/walletConnect.js
@@ -316,6 +318,13 @@ export function* onSessionRequest(action) {
} catch (e) {
let shouldAnswer = true;
switch (e.constructor) {
case BluePrintNotFoundError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I believe the name for this error will change to BlueprintNotFoundError, pointed in this comment.

@andreabadesso andreabadesso force-pushed the feat/rpc-lib-integration branch 2 times, most recently from b23f09c to 2a6ebf7 Compare August 31, 2024 21:09
Base automatically changed from feat/rpc-lib-integration to master September 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexruzenhack alexruzenhack alexruzenhack approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabadesso @pedroferreira1 @alexruzenhack