Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain-deployment #6

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Multichain-deployment #6

merged 3 commits into from
Sep 15, 2024

Conversation

spengrah
Copy link
Member

Changes the implementation deployment flow to ensure that deployments to EVM chains are always to the same address.

Since the unlock protocol address differs by network, we set in an initializer rather than the constructor to keep the initCode constant across networks.

Copy link

Changes to gas cost

Generated at commit: 09f617658db9c5bc9b9a146d39bcd613ced7a093, compared to commit: e91a34bc9820a854c85e7b5300f338c1ebaa8700

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
PublicLockV14Eligibility 1,493,809 (+1,493,809) lock 401 (0) 0.00% 2,161 (+68) +3.25% 2,401 (0) 0.00% 2,401 (0) 0.00% 25 (-1)
DeployInstance 1,167,181 (0) prepare
run
50,063 (0)
1,275,471 (0)
0.00%
0.00%
68,229 (-14)
1,292,379 (-40)
-0.02%
-0.00%
68,406 (0)
1,292,583 (+12)
0.00%
+0.00%
68,406 (0)
1,292,583 (+12)
0.00%
+0.00%
104 (-9)
104 (-9)

Copy link

@gershido gershido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spengrah spengrah merged commit 64b3c1f into main Sep 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants